8000 Fix prefix and suffix transforms - avoid adding empty suffix or prefix by sersh88 · Pull Request #57 · eole-nlp/eole · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix prefix and suffix transforms - avoid adding empty suffix or prefix #57

New issue
Merged
merged 3 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eole/decoders/ensemble.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def forward(self, emb, enc_out=None, src_len=None, step=None, **kwargs):
enc_out=None if enc_out is None else enc_out[i],
src_len=src_len,
step=step,
**kwargs
**kwargs,
)
for i, model_decoder in enumerate(self.model_decoders)
]
Expand Down
6 changes: 3 additions & 3 deletions eole/transforms/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def warm_up(self, vocabs=None):
def _prepend(self, example, prefix):
"""Prepend `prefix` to `tokens`."""
for side, side_prefix in prefix.items():
if example.get(side) is not None:
if example.get(side) is not None and len(side_prefix) > 0:
example[side] = side_prefix.split(" ") + example[side]
elif len(side_prefix) > 0:
example[side] = side_prefix.split(" ")
Expand All @@ -167,7 +167,7 @@ def apply(self, example, is_train=False, stats=None, **kwargs):

def apply_reverse(self, predicted):
def _removeprefix(s, prefix):
if s.startswith(prefix) and len(prefix) > 0:
if len(prefix) > 0 and s.startswith(prefix):
return s[len(prefix) + 1 :]
else:
return s
Expand Down Expand Up @@ -249,7 +249,7 @@ def warm_up(self, vocabs=None):
def _append(self, example, suffix):
"""Prepend `suffix` to `tokens`."""
for side, side_suffix in suffix.items():
if example.get(side) is not None:
if example.get(side) is not None and len(side_suffix) > 0:
example[side] = example[side] + side_suffix.split(" ")
elif len(side_suffix) > 0:
example[side] = side_suffix.split(" ")
Expand Down
Loading
0