[fix] Allow to build_vocab with full train config, patch vocab validation #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all configs are set with
extra="allow"``. To facilitate building the vocab with a full train config, e.g. inwiki_103orwmt17, we'll be more permissive forBuildVocabConfig`.Note: pydantic 2.8.0 upgrade triggers errors that were not raised before. This outlined some remaining issues around some vocab/data validation logic. This PR provides some patches, but this logic might be reviewed more in depth at some point.
A somewhat cleaner way might be to nest the VocabConfig in a
vocabkey, and pop it when needed (like already done fordatain some places).