-
Notifications
You must be signed in to change notification settings - Fork 461
docs: dynamic resolver backend #5935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f86c3b0
to
27866ff
Compare
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
27866ff
to
3738e7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
==========================================
+ Coverage 65.80% 65.87% +0.06%
==========================================
Files 217 217
Lines 36020 36020
==========================================
+ Hits 23703 23727 +24
+ Misses 10836 10818 -18
+ Partials 1481 1475 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thanks @zhaohuabing ! can we add this as a section within https://gateway.envoyproxy.io/docs/tasks/traffic/backend/ ? |
@arkodg Not a strong opinion, but since the tasks are arranged by features, I slightly prefer keeping "dynamic forward proxy" as a standalone task. The Having it as a standalone task also makes it easier for users to discover this powerful feature. |
@zhaohuabing was recommending the main page because it highlights
else this will need to be duplicated |
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Hi @arkodg moved it to the backend main page. I kept the section title as "Dynamic Forward Proxy" since I feel it's a bit easier to understand for readers at first glance. But if you prefer "Dynamic Resolver" , I'm happy to update it. |
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
No description provided.