8000 docs: dynamic resolver backend by zhaohuabing · Pull Request #5935 · envoyproxy/gateway · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: dynamic resolver backend #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 10, 2025

Conversation

zhaohuabing
Copy link
Member

No description provided.

@zhaohuabing zhaohuabing requested a review from a team as a code owner May 6, 2025 07:39
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-docs branch from f86c3b0 to 27866ff Compare May 6, 2025 07:40
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing force-pushed the dynamic-resolver-docs branch from 27866ff to 3738e7f Compare May 6, 2025 07:43
Copy link
codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.87%. Comparing base (9b78828) to head (9b63133).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
+ Coverage   65.80%   65.87%   +0.06%     
==========================================
  Files         217      217              
  Lines       36020    36020              
==========================================
+ Hits        23703    23727      +24     
+ Misses      10836    10818      -18     
+ Partials     1481     1475       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shawnh2
shawnh2 previously approved these changes May 6, 2025
@arkodg
Copy link
Contributor
arkodg commented May 6, 2025

thanks @zhaohuabing ! can we add this as a section within https://gateway.envoyproxy.io/docs/tasks/traffic/backend/ ?
Also can we refer to this as Dynamic Resolver, and refer to the under the hood implementation using Envoy's Dynamic Forward Proxy in the overview

@zhaohuabing
Copy link
Member Author

@arkodg Not a strong opinion, but since the tasks are arranged by features, I slightly prefer keeping "dynamic forward proxy" as a standalone task. The DynamicResolver type of Backend is the way this feature is implemented in Envoy Gateway.

Having it as a standalone task also makes it easier for users to discover this powerful feature.

@arkodg
Copy link
Contributor
arkodg commented May 7, 2025

@zhaohuabing was recommending the main page because it highlights

  • security implications around using Backend in general
  • steps to enable Backend API

else this will need to be duplicated

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing
Copy link
Member Author
zhaohuabing commented May 8, 2025

Hi @arkodg moved it to the backend main page. I kept the section title as "Dynamic Forward Proxy" since I feel it's a bit easier to understand for readers at first glance. But if you prefer "Dynamic Resolver" , I'm happy to update it.

@zhaohuabing zhaohuabing requested review from shawnh2 and a team May 9, 2025 02:26
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing added this to the v1.4.0 milestone May 9, 2025
Copy link
Contributor
@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team May 9, 2025 17:50
@shawnh2 shawnh2 merged commit 442de3d into envoyproxy:main May 10, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0