doc/md: various improvements to gRPC tutorial #2977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add titles to code descriptions when files have well known location * Renovate code that generates differently now * Change ID type to int64 to match current generation
|
Thanks for the contribution @kortschak ! Excuse my question, I'm on the go so didn't check myself yet. All of the modifications to the generated code, are they based on a newer version of entgrpc or suggestions to make the code nicer ? It's been a while since I wrote this and so I ask. |
|
The changes are there to reflect the changes in the generated code. Some changes probably want to be made in the tutorial repo as well since it currently doesn't build. |
rotemtam
approved these changes
Sep 30, 2022
|
@all-contributors please add @kortschak for docs |
|
I've put up a pull request to add @kortschak! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.