dialect/sql/entsql: support including non-key columns in postgres indexes #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
thuan1412
reviewed
Sep 8, 2022
Comment on lines
+239
to
+242
| index.Fields("workplace"). | ||
| Annotations( | ||
| entsql.IncludeColumns("address"), | ||
| ), |
There was a problem hiding this comment.
I think we need to add the example to the generated examples too.
CREATE INDEX users ON users USING (workplace) INCLUDE (nickname)
There was a problem hiding this comment.
Hey and thanks for the review.
What do you mean by “generated examples”?
There was a problem hiding this comment.
I mean this section in the doc
There was a problem hiding this comment.
Oh, great catch. Would you like to contribute this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.