8000 dialect/sql: fixed invalid json path quote by giautm · Pull Request #2910 · ent/ent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dialect/sql: fixed invalid json path quote #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2022
Merged

dialect/sql: fixed invalid json path quote #2910

merged 5 commits into from
Sep 7, 2022

Conversation

giautm
Copy link
Collaborator
@giautm giautm commented Sep 7, 2022

No description provided.

a8m
a8m approved these changes Sep 7, 2022
View reviewed changes
giautm and others added 2 commits September 7, 2022 18:26
@giautm @a8m
Apply suggestions from code review
54aed3c 
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
@giautm
fix: added test to new case
5dd5eb1
a8m
a8m approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member
@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@a8m a8m merged commit 2cdb627 into ent:master Sep 7, 2022
@giautm giautm deleted the giautm/sqljson branch September 7, 2022 11:50
@timoha timoha mentioned this pull request Oct 7, 2022
Closed
@giautm giautm restored the giautm/sqljson branch March 30, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giautm @a8m
0