Init template #2728
Merged
Init template #2728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
requested changes
Jul 23, 2022
cmd/internal/base/base.go
Outdated
Comment on lines
75
to
76
| "ent init --template '<template string>'", | ||
| "ent init --template file=path/to/tmpl.tmpl", |
There was a problem hiding this comment.
Suggested change
| "ent init --template '<template string>'", | |
| "ent init --template file=path/to/tmpl.tmpl", | |
| "ent init --template file=path/to/file.tmpl User", |
There was a problem hiding this comment.
Please, let's not support string template atm. It's not supported by ent generate and I don't see a use case for it.
There was a problem hiding this comment.
thought I saw it elsewhere (?)
took a second look and couldn't find, will remove
cmd/internal/base/base.go
Outdated
Comment on lines
67
to
68
| var target string | ||
| var newSchemaTemplate string |
There was a problem hiding this comment.
Suggested change
| var target string | |
| var newSchemaTemplate string | |
| var target, tmpl string |
Keep variable names short please.
dhuckins
commented
Jul 25, 2022
a8m
approved these changes
Jul 26, 2022
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
|
@a8m suggestions applied! needs an approval from a contributor to run CI checks thanks! |
a8m
approved these changes
Jul 27, 2022
|
Please, you are welcome to join our Discord community. |
70F5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows
ent init ...to accept template string/file for new model creation