8000 feat: update tablewriter to v1.0.7 and refactor usage by ml1nk · Pull Request #4407 · ent/ent · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: update tablewriter to v1.0.7 and refactor usage #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: update tablewriter to v1.0.7 and refactor usage #4407

wants to merge 1 commit into from

Conversation

ml1nk
Copy link
@ml1nk ml1nk commented Jun 23, 2025

Tablewriter was updated to v1 and contains some breaking changes. In our codebase we got an error after updating some other dependency which depends on tablewriter v1.

# entgo.io/ent/cmd/internal/printer
/go/pkg/mod/entgo.io/ent@v0.14.4/cmd/internal/printer/printer.go:50:8: table.SetAutoFormatHeaders undefined (type *tablewriter.Table has no field or method SetAutoFormatHeaders)
/go/pkg/mod/entgo.io/ent@v0.14.4/cmd/internal/printer/printer.go:51:8: table.SetHeader undefined (type *tablewriter.Table has no field or method SetHeader)
/go/pkg/mod/entgo.io/ent@v0.14.4/cmd/internal/printer/printer.go:70:8: table.SetAutoFormatHeaders undefined (type *tablewriter.Table has no field or method SetAutoFormatHeaders)
/go/pkg/mod/entgo.io/ent@v0.14.4/cmd/internal/printer/printer.go:71:8: table.SetHeader undefined (type *tablewriter.Table has no field or method SetHeader)
/go/pkg/mod/entgo.io/ent@v0.14.4/cmd/internal/printer/printer.go:84:11: table.NumLines undefined (type *tablewriter.Table has no field or method NumLines)
ent/generate.go:4: running "go": exit status 1

@giautm giautm requested a review from a8m June 23, 2025 10:50
@ml1nk ml1nk force-pushed the feature/tablewriter branch from 588125c to 77e7b35 Compare June 23, 2025 15:24
@ml1nk
Copy link
Author
ml1nk commented Jun 23, 2025

Made linter happy by ignoring errors which cannot occur in this usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m Awaiting requested review from a8m

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ml1nk
0