Prepare releases #1379
Merged
Prepare releases #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes this covers are 7.4.0...main
I have verified this PR works with
What else has been done to verify that this works as intended?
I did all of the above with the image at https://github.com/enketo/enketo/pkgs/container/enketo/319695763?tag=prep-release
Why is this the best possible solution? Were any other approaches considered?
There are currently 3 LTS node versions including 18 (https://nodejs.org/en/about/previous-releases). 18 will go out of maintenance LTS in May of 2025. I briefly considered testing all 3. Given that Node 20 is in maintenance LTS as well, it feels simpler to me to drop 18 now and support the two latest LTS versions.
We've previously done major version changes when changing supported node versions. I don't think we should do this anymore. Here's a good summary of why: https://rtpg.co/2023/09/27/avoiding-major-version-bumps-for-node/
I upgraded specific dependencies involved in security issues or with likely useful improvements since
yarn upgradebreaks transformer tests.I briefly explored upgrading eslint to 9 since it's the source of some of our security warnings. Of course, it's only used in development so the security issues don't apply, they just make for some noise. I backed out quickly when I ran into some OOM issues and issues with the cache file. Here's the branch: https://github.com/lognaturel/enketo/tree/eslint9
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I think the biggest risk with these releases is around the change to signature/draw/annotate questions. I tried to point to useful resources for folks who use Core with their own file manager but I could imagine that upgrade being confusing. There could also very well be regressions or new undesirable behavior in that area.
Do we need any specific form for testing your changes? If so, please attach one.