8000 Upgrade bundler to v2 by brendanshean · Pull Request #8906 · empirical-org/Empirical-Core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade bundler to v2 #8906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2022
Merged

Upgrade bundler to v2 #8906

merged 4 commits into from
Mar 9, 2022

Conversation

brendanshean
Copy link
Member
@brendanshean brendanshean commented Mar 7, 2022 •
edited
Loading

WHAT

Upgrade bundler from 1.17.3 to 2.2.33.

WHY

There's an incompatibility with M1 ARM architecture and our current version of mini_racer and the dependency libv8. One workaround involves using the rosetta2 emulator to build gems using the older intel architecture. However, this eliminates the benefit of the ARM processor. By upgrading bundler we don't have to use rosetta2 anymore. A more standard solution is simply upgrading bundler to v2.

Also, Heroku supports bundler v2 and future upgrades to ruby will be streamlined with using a newer version of bundler.

HOW

After gem install -v 2.2.33, run bundle update --bundler.

Screenshots

(If applicable. Also, please censor any sensitive data)

Notion Card Links

(Please provide links to any relevant Notion card(s) relevant to this PR.)

PR Checklist Your Answer
Have you added and/or updated tests? No. Configuration change.
Have you deployed to Staging? YES
Self-Review: Have you done an initial self-review of the code below on Github? YES
Spec Review: Have you reviewed the spec and ensured this meets requirements and/or matches design mockups? N/A

@brendanshean brendanshean requested review from anathomical, dandrabik and happythenewsad and removed request for anathomical and dandrabik March 7, 2022 17:45
anathomical
anathomical requested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor
@anathomical anathomical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually see any place where this is actually specified. I presume that that's because bundler is sort of outside the framework. That said, we should at least update bin/dev/bootstrap.sh which has a note about pinning an older version due to incompatibility.

@brendanshean
Copy link
Member Author

I don't actually see any place where this is actually specified. I presume that that's because bundler is sort of outside the framework. That said, we should at least update bin/dev/bootstrap.sh which has a note about pinning an older version due to incompatibility.

My guess is that circleci picks up the bundler version in the Gemfile.lock but I also couldn't find anything explicit as to why that current version of bundler is there without a gem install call.

Good point on the bin/dev/bootstrap.sh
I will update that.

@brendanshean brendanshean requested a review from anathomical March 7, 2022 18:19
dandrabik
dandrabik approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member
@dandrabik dandrabik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for testing this helpful upgrade!

@brendanshean brendanshean temporarily deployed to quill-lms-brendan March 8, 2022 18:00 Inactive
@brendanshean brendanshean merged commit 0a4fac4 into develop Mar 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the bs-upgrade-bundler branch March 9, 2022 13:44
brendanshean added a commit that referenced this pull request Mar 9, 2022
@brendanshean
Merge pull request #8916 from empirical-org/develop
a666347 
Upgrade bundler to v2 (#8906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happythenewsad happythenewsad happythenewsad approved these changes

@anathomical anathomical anathomical approved these changes

@dandrabik dandrabik dandrabik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendanshean @happythenewsad @anathomical @dandrabik
0