8000 Fix: make sure the cache file is writable by emmercm · Pull Request #1070 · emmercm/igir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: make sure the cache file is writable #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 7, 2024
Merged

Fix: make sure the cache file is writable #1070

merged 5 commits into from
Apr 7, 2024

Conversation

emmercm
Copy link
Owner
@emmercm emmercm commented Apr 6, 2024

RE: #1060

@emmercm emmercm self-assigned this Apr 6, 2024
@emmercm emmercm mentioned this pull request Apr 6, 2024
Closed
@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 6, 2024 •
edited
Loading

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/test-cache-is-writable" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm enabled auto-merge (squash) April 7, 2024 04:04
@codecov Codecov
Copy link
codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.37%. Comparing base (3b6579b) to head (0f20d82).

Files Patch % Lines
src/constants.ts 90.00% 1 Missing ⚠️
src/polyfill/fsPoly.ts 87.50% 1 Missing ⚠️
src/types/cache.ts 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
+ Coverage   93.11%   93.37%   +0.26%     
==========================================
  Files          92       92              
  Lines        6009     6024      +15     
  Branches     1436     1436              
==========================================
+ Hits         5595     5625      +30     
+ Misses        392      378      -14     
+ Partials       22       21       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit dbf5566 into main Apr 7, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/test-cache-is-writable branch April 7, 2024 04:11
@github-actions GitHub Actions
Copy link
github-actions bot commented May 8, 2024

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@emmercm emmercm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmercm
0