8000 Fix `leading_space` sometimes being ignored during paragraph splitting by afishhh · Pull Request #7031 · emilk/egui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix leading_space sometimes being ignored during paragraph splitting #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2025
Merged

Fix leading_space sometimes being ignored during paragraph splitting #7031

merged 2 commits into from
May 8, 2025

Conversation

afishhh
Copy link
Contributor
@afishhh afishhh commented May 7, 2025

Fixes a regression introduced in #5411 (possibly d74bee5) that breaks leading_space handling.
I think this is what the condition should be but I haven't touched this code in a while.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 7, 2025

Preview available at https://egui-pr-preview.github.io/pr/7031-fix-leading-space
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

emilk
emilk approved these changes May 8, 2025
View reviewed changes
Copy link
Owner
@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

We should add a test case for this at the end of the file too (just set leading_space in one of the test cases)

@emilk emilk added this to the 0.32.0 milestone May 8, 2025
@lucasmerlin lucasmerlin added bug Something is broken egui labels May 8, 2025
@afishhh
Move leading_space case to second line in paragraph splitting test
1b5b23e 
This allows it to catch issues with `leading_space` if they only
occur after the first paragraph, which is a likely case.
@afishhh
Copy link
Contributor Author
afishhh commented May 8, 2025

I swapped the leading_space section of the test that had it with the section after it so that the leading_space is in the second paragraph, alternatively I can also add another section or add leading_space to one of the other ones if that's desired.

@emilk emilk merged commit e9609ac into emilk:main May 8, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
3 participants
@afishhh @emilk @lucasmerlin
0