8000 client: Use non-synchronizing literals when length is small (<4096) by foxcpp · Pull Request #273 · emersion/go-imap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

client: Use non-synchronizing literals when length is small (<4096) #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2019
Merged

client: Use non-synchronizing literals when length is small (<4096) #273

merged 2 commits into from
Jun 10, 2019

Conversation

foxcpp
Copy link
Collaborator
@foxcpp foxcpp commented Jun 10, 2019

Closes #7.

@codecov
Copy link
codecov bot commented Jun 10, 2019 •
edited
Loading

Codecov Report

Merging #273 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
====
8000
======================================
+ Coverage   72.97%   72.97%   +<.01%     
==========================================
  Files          32       32              
  Lines        3452     3460       +8     
==========================================
+ Hits         2519     2525       +6     
- Misses        641      642       +1     
- Partials      292      293       +1
Impacted Files Coverage Δ
client/client.go 62.69% <66.66%> (-0.17%) ⬇️
write.go 69.49% <83.33%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bdc3f8...3141887. Read the comment docs.

emersion
emersion reviewed Jun 10, 2019
View reviewed changes
emersion
emersion approved these changes Jun 10, 2019
View reviewed changes
Copy link
Owner
@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests

I was wondering whether it's worth it to check for errors after c.Support calls, but it's probably not worth it.

@emersion emersion merged commit 679123b into emersion:master Jun 10, 2019
@emersion
Copy link
Owner

Thanks!

@foxcpp foxcpp deleted the literal-plus-client branch June 10, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement IMAP4 non-synchronizing literals
2 participants
@foxcpp @emersion
0