8000 Use less restrictve Dialer interface in DialWithDialer by foxcpp · Pull Request #249 · emersion/go-imap · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use less restrictve Dialer interface in DialWithDialer #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2019
Merged

Use less restrictve Dialer interface in DialWithDialer #249

merged 2 commits into from
May 21, 2019

Conversation

foxcpp
Copy link
Collaborator
@foxcpp foxcpp commented May 21, 2019

Closes #201.

@foxcpp foxcpp force-pushed the dialer branch 2 times, most recently from 1923032 to 1cf06fa Compare May 21, 2019 15:57
@foxcpp
Copy link
Collaborator Author
foxcpp commented May 21, 2019

Woops.

@codecov
Copy link
codecov bot commented May 21, 2019 •
edited
Loading

Codecov Report

Merging #249 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   72.97%   72.94%   -0.03%     
==========================================
  Files          32       32              
  Lines        3389     3390       +1     
==========================================
  Hits         2473     2473              
- Misses        628      629       +1     
  Partials      288      288
Impacted Files Coverage Δ
client/client.go 61.03% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ca724...21148f1. Read the comment docs.

@foxcpp foxcpp requested a review from emersion May 21, 2019 16:03
@foxcpp
Copy link
Collaborator Author
foxcpp commented May 21, 2019

Okay, I fixed it.

emersion
emersion reviewed May 21, 2019
View reviewed changes
@emersion emersion merged commit d64fc14 into emersion:master May 21, 2019
@emersion
Copy link
Owner

Thanks!

@foxcpp foxcpp deleted the dialer branch May 21, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion

emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How would you use Socks5 dialer?
2 participants
@foxcpp @emersion
0