8000 add branching and submodule imports by rmorshea · Pull Request #1 · ellisonbg/antipackage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add branching and submodule imports #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 47 commits into from

Conversation

rmorshea
Copy link
@rmorshea rmorshea commented Jan 25, 2015

main

Users can now import modules using branches, tags, or specific commits by way of pins (small data structures stored in .antipackage/pinnings.json). The README.md and doc files have been updated to explain how to enable this new functionality.

notes

@ellisonbg
Copy link
Owner

I think having two top-level objects is a bit more complex than needed. Let's try to do this in one main object. Here is how:

  • Have a top-level set_branch('github.org.repo','branchname') function that sets the branch for a particular repo. Should also have get_branch(repo) that should simply default to master that we will use when building the URLs.
  • Make the main object work with both single files and subpackages.

I think this will simplify things a lot.

@rmorshea
Copy link
Author

bugs present at the moment

@rmorshea
Copy link
Author

should be fixed now

@ellisonbg
8000 Copy link
Owner

OK great, I will have a look soon!

On Thu, Apr 30, 2015 at 2:40 AM, Ryan Morshead notifications@github.com
wrote:

should be fixed now


Reply to this email directly or view it on GitHub
#1 (comment).

Brian E. Granger
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com

@ellisonbg
Copy link
Owner

rebase?

antipackage.py Outdated
print('Using existing version of: %s' % reponame)
return False

def install(self):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the install method to the GitHubRepo and give it the signature download(self, path) where path is the location the directory will end up. The _install_init should not be done in that new method though.

Copy link
@reteps reteps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@rmorshea rmorshea closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4F7C Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import URL pointing to specific commit, tag, etc can't include dashes in username
3 participants
0