-
Notifications
You must be signed in to change notification settings - Fork 8
add branching and submodule imports #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think having two top-level objects is a bit more complex than needed. Let's try to do this in one main object. Here is how:
I think this will simplify things a lot. |
bugs present at the moment |
should be fixed now |
OK great, I will have a look soon! On Thu, Apr 30, 2015 at 2:40 AM, Ryan Morshead notifications@github.com
Brian E. Granger |
rebase? |
antipackage.py
Outdated
print('Using existing version of: %s' % reponame) | ||
return False | ||
|
||
def install(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move the install method to the GitHubRepo
and give it the signature download(self, path)
where path
is the location the directory will end up. The _install_init
should not be done in that new method though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
main
Users can now import modules using branches, tags, or specific commits by way of pins (small data structures stored in
.antipackage/pinnings.json
). The README.md and doc files have been updated to explain how to enable this new functionality.notes
import_replacement
allows for substitutions on import statements,which resolves the error that a special character like a
-
might raise when callingimport github.jdfreder.ipython-d3networkx
. See the readme for more info.