added method Flat
#187
Merged
added method Flat
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flat & FlatMap
Flat & FlatMap
elliotchance
requested changes
Feb 12, 2023
v2/of.go
Outdated
| @@ -57,6 +57,10 @@ func (o OfSlice[T]) FirstOr(defaultValue T) T { | |||
| return FirstOr(o.Result, defaultValue) | |||
| } | |||
|
|
|||
| func (o OfSlice[T]) FlatMap(fn func(T) []T) OfSlice[T] { | |||
There was a problem hiding this comment.
Flat works with a 2-dimensional array, I'm not sure it should be part of the OfSlice type
There was a problem hiding this comment.
Yes, it should be part of OfSlice since it deals with slices.
There was a problem hiding this comment.
It's impossible to add Flat to the OfSlice type because Result is a one-dimensional slice ([]T) but Flat works with a two-dimensional slice ([][]T) so this does not work:
func (o OfSlice[T]) Flat() []T {
return OfSlice[T]{Flat(o.Result)}
}
if you mean another way to add it to the OfSlice type I'll be thankful for your help
There was a problem hiding this comment.
Ah, I see what you mean. That's fair - you can leave it out.
elliotchance
requested changes
Feb 16, 2023
v2/of.go
Outdated
| @@ -57,6 +57,10 @@ func (o OfSlice[T]) FirstOr(defaultValue T) T { | |||
| return FirstOr(o.Result, defaultValue) | |||
| } | |||
|
|
|||
| func (o OfSlice[T]) FlatMap(fn func(T) []T) OfSlice[T] { | |||
There was a problem hiding this comment.
Yes, it should be part of OfSlice since it deals with slices.
elliotchance
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.