8000 fix(electron-updater): allow forceDevUpdateConfig also on Linux by Lemonexe · Pull Request #9024 · electron-userland/electron-builder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(electron-updater): allow forceDevUpdateConfig also on Linux #9024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2025
Merged

fix(electron-updater): allow forceDevUpdateConfig also on Linux #9024

merged 2 commits into from
May 3, 2025

Conversation

Lemonexe
Copy link
Contributor
@Lemonexe Lemonexe commented Apr 11, 2025 •
edited
Loading

A DX improvement for development on Linux:

  • Currently, you may override appUpdater.forceDevUpdateConfig = true to test fetching and parsing update config.
  • But it works only on macOS and Windows, where isUpdaterActive is called directly on AppUpdater.
  • On Linux, AppImageUpdater overrides this method and early returns false on dev.
  • So you have to also set APPIMAGE=true env to get the same behavior.
  • This PR removes the need for this workaround.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Apr 11, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 56b7e08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Lemonexe Lemonexe marked this pull request as ready for review April 11, 2025 07:08
@mmaietta
Copy link
Collaborator

Based on https://github.com/electron-userland/electron-builder/pull/9024/files#diff-f670e73a74bd05ee25dafba71f25a5d9cbe1c674b424c9e7db001563348901beL79-L82

I'm under the impression that APPIMAGE needs to be present in order for an installation to proceed during doInstall, so how does this PR handle the auto-update of a dev AppImage?

@Lemonexe
Copy link
Contributor Author

@mmaietta Sure, it is not possible to follow-up with an update. This merely enables you to query for available updates on dev environment. After all, that is available on Windows & macOS dev environments by the forceDevUpdateConfig=true option, and there you cannot "update the dev environment" either, right?. This just aligns the possibilities on Linux dev env with Windows & macOS.
But feel free to close the PR if it does not make sense 🙂

@mmaietta
Copy link
Collaborator

Let me investigate this further just to make sure we don't miss any edge cases. If anything comes up, I think I can push directly to this PR using gh CLI

@Lemonexe
Copy link
Contributor Author

@mmaietta Ok, but feel free to close if this is off track, this is really not a big deal 🙂
The only DX inconvenience is that when I run dev env of an electron app, and I want to test querying updates , I have to do this:

APPIMAGE=true npm start-my-electron-app

Naturally, I cannot proceed with the update on dev env. But I can test querying them when I set forceDevUpdateConfig

@mmaietta
Copy link
Collaborator
mmaietta commented May 3, 2025

LGTM. Thanks for your contribution!

@mmaietta mmaietta changed the title chore(electron-updater): allow forceDevUpdateConfig also on Linux fix(electron-updater): allow forceDevUpdateConfig also on Linux May 3, 2025
@mmaietta mmaietta merged commit e641751 into electron-userland:master May 3, 2025
19 checks passed
This was referenced May 3, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta approved these changes

Assignees
No one assigned
Labels
electron-updater
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lemonexe @mmaietta
0