fix: use 'target_arch' for node-pre-gyp #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
+ Coverage 76.78% 77.06% +0.27%
==========================================
Files 21 21
Lines 741 763 +22
Branches 140 142 +2
==========================================
+ Hits 569 588 +19
- Misses 121 122 +1
- Partials 51 53 +2 ☔ View full report in Codecov by Sentry. |
MarshallOfSound
approved these changes
Nov 18, 2023
|
aea4654 will unfortunately cause the binaries to be redownloaded each time a rebuild occurs. node-pre-gyp doesn't update the binary without the |
|
@samuelmaddock is there a way that we can be smarter here for them? E.g. detect a .node file with the wrong arch and nuke it Not super fussed but would be nice if it's not too hard |
7129520 to
cbd44e4
Compare
MarshallOfSound
approved these changes
Dec 4, 2023
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments provided to node-pre-gyp are incomplete, resulting in prebuilt binaries not downloading the correct architecture. From the readme,
--target_archand--target_platformare both used for downloading the prebuilt binaries. The--archoption seems to only be used when falling back to thenode-gyplocal build.Also, if the binary already exists,
--update-binaryis required to redownload in the case of changing the targeted architecture.Follow up to #1095