8000 fix(targets): linux/ia32 official support was removed in Electron 19 by malept · Pull Request #1449 · electron/packager · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(targets): linux/ia32 official support was removed in Electron 19 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

malept
Copy link
Member
@malept malept commented Nov 21, 2022
  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Compare the assets of 19.0.0-alpha.5 with 19.0.0-beta.1.

Fixes #1447

@malept malept requested a review from a team November 21, 2022 23:08
@codecov
Copy link
codecov bot commented Nov 21, 2022

Codecov Report

Merging #1449 (4dd1541) into main (4f9cc44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          15       15           
  Lines         793      793           
=======================================
  Hits          758      758           
  Misses         35       35           
Impacted Files Coverage Δ
src/targets.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@malept malept merged commit 95d0754 into main Nov 22, 2022
@malept malept deleted the malept/fix/rip-linux-ia32 branch November 22, 2022 00:22
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to campersau/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to FredrikNoren/ungit that referenced this pull request Jun 29, 2023
waiting for new electron-packager release which includes electron/packager#1449
campersau added a commit to FredrikNoren/ungit that referenced this pull request Jun 29, 2023
* Bump Dependencies

* Bump minimum node version to 16

* CI: Bump create-pull-request to v5

* Fix electron-packager to not include linux ia32

waiting for new electron-packager release which includes electron/packager#1449

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-all should not attempt to build Linux/ia32 since it fails to find required files
2 participants
0