8000 chore: update to Electron 19.0.14 by miniak · Pull Request #1169 · electron/fiddle · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update to Electron 19.0.14 #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: update to Electron 19.0.14 #1169

wants to merge 1 commit into from

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Aug 28, 2022

Tested locally on macOS Monterey (12.5.1) and Windows 11.

@coveralls
Copy link
coveralls commented Aug 28, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 92.411% when pulling 1ab33ed on miniak:electron-19 into 866ff97 on electron:main.
8000

@miniak
Copy link
Contributor Author
miniak commented Aug 28, 2022 •
edited
Loading

crashes here, seems to be caused by electron/electron#35337

uv__loop_interrupt (in Electron Framework) (loop.c:259)
uv__async_stop (in Electron Framework) (async.c:216)
uv__loop_close (in Electron Framework) (loop.c:172)
uv_loop_close (in Electron Framework) (uv-common.c:0)
electron::NodeBindings::~NodeBindings() (in Electron Framework) (node_bindings.cc:342)
electron::MainApplicationBundle() (in Electron Framework) (main_application_bundle.mm:62)
electron::WebWorkerObserver::ContextWillDestroy(v8::Local<v8::Context>) (in Electron Framework) (web_worker_observer.cc:87)
...

This was referenced Aug 28, 2022
Merged
Closed
@miniak miniak closed this Aug 31, 2022
@miniak miniak deleted the electron-19 branch August 31, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere Awaiting requested review from codebytere codebytere will be requested when the pull request is marked ready for review codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miniak @coveralls
0