Pass uploadToServer option to windows crash reporter
#9053
Conversation
1add065 to
681e4d2
Compare
lib/common/api/crash-reporter.js
Outdated
| throw new Error('submitURL is a required option to crashReporter.start') | ||
| } else { | ||
| // use a dummy upload URL | ||
| submitURL = 'http://dummy/upload/url' |
There was a problem hiding this comment.
Hmm, so if you call start with uploadToServer with false and no submitURL and then later call setUploadToServer(true) and then get a crash, you'll see your machine make a request to this URL right?
Would an empty submit URL be possible to use instead? Or does that cause issues somewhere else?
There was a problem hiding this comment.
later call setUploadToServer(true) and then get a crash, you'll see your machine make a request to this URL right
Yes, I considered using http://localhost but it is possible that the user has a local http server.
681e4d2 to
67d92ef
Compare
67d92ef to
460fb9c
Compare
|
Thanks for adding support for this @tarruda 👍 🏁 |
|
Just got a flaky looking failure here on AppVeyor: https://ci.appveyor.com/project/electron-bot/electron/build/244/job/rp59bmb2epvvbh52#L1518 Perhaps we should use |
The file is deleted is to ensure the crash dump is created(and not uploaded), my guess is that the crash reporter was still writing to the file when In any case, I think it is better to not depend on |
Note that
get/setUploadToServeris not implemented because the CustomInfo structure is only set whenstartis called, so to change the value ofuploadToServerthe user needs to callstartagain(which is how it already works for most options).