8000 Throw custom error when remote object is missing from registry by kevinsawicki · Pull Request #8003 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Throw custom error when remote object is missing from registry #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2016

Conversation

kevinsawicki
Copy link
Contributor
@kevinsawicki kevinsawicki commented Nov 17, 2016

This pull request replaces the Uncaught Error: Cannot read property 'object' of undefined errors thrown when calling a remote function that is missing from the object registry with custom error messages that include the name of the method/property and the id of the missing object.

These have started cropping up on CI and so this is an attempt to track them down further.

The EBADRPC code is set on the errors:

72 EBADRPC RPC struct is bad. Exchange of RPC information was unsuccessful.

Refs #7351

@kevinsawicki
Copy link
Contributor Author

Going to merge this to get this running on other pull requests that are failing to see if it gets triggered. Can revert later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0