Prevent systemPreferences.getUserDefault crash for missing arrays/dictionaries #7993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to return undefined or null instead? |
I thought about that a bit, it looks like numbers, booleans, strings, and urls return valid values instead of undefined/null when their missing so empty arrays/objects seemed to make it consistent with that existing behavior. |
😢 |
zeke
approved these changes
Nov 18, 2016
3063faf to
2613797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NSArrayToListValueandNSDictionaryToDictionaryValuereturn null pointers when the given value is null which is the case when the requested user default is not an array or dictionary.This pull requests returns empty array/objects instead of crashing when this happens.
Also adds specs for the values returned when the key has no default.
Fixes #7993