8000 Memoize ELECTRON_NO_ASAR env var check by kevinsawicki · Pull Request #7978 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Memoize ELECTRON_NO_ASAR env var check #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2016
Merged

Memoize ELECTRON_NO_ASAR env var check #7978

merged 1 commit into from
Nov 16, 2016

Conversation

kevinsawicki
Copy link
Contributor
@kevinsawicki kevinsawicki commented Nov 15, 2016 •
edited
Loading

The ELECTRON_NO_ASAR var is supported for spawned/forked child processes so it only needs to be checked once and the value can be cached for future calls.

🐎 Seeks to improve on the costly checks reported in #7948

/cc @paulcbetts 👀

Closes #7948

@kevinsawicki kevinsawicki force-pushed the memoize-no-asar-env-check branch from a0b3bba to 9976fd4 Compare November 16, 2016 15:23
@kevinsawicki kevinsawicki force-pushed the memoize-no-asar-env-check branch from 9976fd4 to bea1a06 Compare November 16, 2016 15:37
@kevinsawicki kevinsawicki merged commit bee5ced into master Nov 16, 2016
@kevinsawicki kevinsawicki deleted the memoize-no-asar-env-check branch November 16, 2016 15:41
@anaisbetts
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinsawicki @anaisbetts
0