Fix notification crash when using permission handler #7788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b45c998 to
da15236
Compare
deepak1556
reviewed
Oct 28, 2016
| session.fromPartition(webview.partition).setPermissionRequestHandler(function (webContents, permission, callback) { | ||
| if (webContents.getId() === webview.getId()) { | ||
| assert.equal(permission, 'notifications') | ||
| callback(true) |
There was a problem hiding this comment.
Do we want to add a delay here before responding, just so it tests for the original issue ?
|
looks good to me 👍 |
091cc47 to
3f8e173
Compare
|
Thanks @deepak1556 for fixing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades Brightray to include electron-archive/brightray#258 and also adds a spec for using
setPermissionRequestHandlerwith notifications.Also updates a few asserts that were using
assertinstead ofassert.equal/assert.deepEqual./cc @deepak1556 👀
Fixes #7645