browser: fix race in creation of default browser context by AtomAccessTokenStore #7628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
This change causes a few seconds freezing of the UI thread when loading a site such as http://www.google.com in webview tag. If you quit the application during that freeze, electrons crash. |
|
@kazkondo I've got the same problem. Is there any possibility to fix this? |
|
@simoncaminada the freezing thread issue has been fixed in #8923 and is available with 1.6.5-beta release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no default browser context is created, multiple calls to
TokenLoadingJobwill cause a race in browser context creation and crash. The patch creates the browser context when access token store is initialized and passes it toTokenLoadingJob.Fixes #7607