8000 Add options to webFrame.registerURLSchemeAsPrivileged by pfrazee · Pull Request #7665 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add options to webFrame.registerURLSchemeAsPrivileged #7665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2016
Merged

Add options to webFrame.registerURLSchemeAsPrivileged #7665

merged 2 commits into from
Oct 24, 2016

Conversation

pfrazee
Copy link
Contributor
@pfrazee pfrazee commented Oct 18, 2016 •
edited by MarshallOfSound
Loading

Closes #7430

Adds an options argument for choosing which features to register:

### `webFrame.registerURLSchemeAsPrivileged(scheme[, options])`

* `scheme` String
* `options` Object (optional)
  * `secure` Default true.
  * `bypassCSP` Default true.
  * `allowServiceWorkers` Default true.
  * `supportFetchAPI` Default true.
  * `corsEnabled` Default true.

MarshallOfSound
MarshallOfSound reviewed Oct 18, 2016
View reviewed changes
docs/api/web-frame.md

* `scheme` String
* `options` Object (optional)
* `secure` Default true.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically each of these properties are optional as well right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should I put an (optional) on each one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, updated.

@pfrazee pfrazee mentioned this pull request Oct 19, 2016
Closed
@zcbenz
Copy link
Contributor
zcbenz commented Oct 24, 2016

👍

@zcbenz zcbenz merged commit ad48aee into electron:master Oct 24, 2016
@kevinsawicki kevinsawicki mentioned this pull request Oct 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfrazee @zcbenz @MarshallOfSound
0