8000 Add showHiddenFiles property for dialog.showOpenDialog by zcbenz · Pull Request #6431 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add showHiddenFiles property for dialog.showOpenDialog #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2016
Merged

Add showHiddenFiles property for dialog.showOpenDialog #6431

merged 4 commits into from
Jul 11, 2016

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jul 11, 2016

Close #3262.

@zcbenz zcbenz merged commit d5a7b3b into master Jul 11, 2016
@zcbenz zcbenz deleted the show-hidden-files branch July 11, 2016 05:58
@bpasero
Copy link
Contributor
bpasero commented Aug 31, 2016

@zcbenz I am trying to use this property via Electron 1.3.4 and in none of the OS I run (Windows 10, Mac OS X 10.11.6, Ubuntu 15) I am seeing an option in the dialog to show hidden files.

I am using the following properties:

  • Mac: 'multiSelections', 'openDirectory', 'openFile', 'createDirectory', 'showHiddenFiles'
  • Windows/Linux: 'multiSelections', 'openFile', 'createDirectory', 'showHiddenFiles'

@zcbenz
Copy link
Contributor Author
zcbenz commented Aug 31, 2016

@bpasero This option just forces the dialog to show all hidden files, adding a toggle in the dialog would involve much more work than this, since it requires custom view.

@bpasero
Copy link
Contributor
bpasero commented Aug 31, 2016

@zcbenz ok got it, I was just looking at the screenshot in #3262 (comment) and was hunting for that toggle, but the way it works now is also perfectly fine 👍

imlucas added a commit to mongodb-js/compass that referenced this pull request Sep 10, 2016
@imlucas
INT-1672: Fix ~/.ssh folder not visible when trying to select ssh tun…
6db02d0 
…nel identity file path

Using the
[`showHiddenFiles`](electron/electron#6431)
dialog option added in electron@1.2.7
@imlucas imlucas mentioned this pull request Sep 10, 2016
Merged
kangas pushed a commit to mongodb-js/compass that referenced this pull request Sep 10, 2016
@imlucas @kangas
INT-1672: Fix ~/.ssh folder not visible when trying to select ssh tun…
0917e7c 
…nel identity file path (#470)

Using the
[`showHiddenFiles`](electron/electron#6431)
dialog option added in electron@1.2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @bpasero
0