Handle remote arguments with no constructor #6369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d65e3ce to
d67dfd0
Compare
| @@ -60,7 +60,7 @@ var wrapArgs = function (args, visited) { | |||
|
|
|||
| ret = { | |||
| type: 'object', | |||
| name: value.constructor.name, | |||
| name: value.constructor != null ? value.constructor.name : 'Object', | |||
There was a problem hiding this comment.
@chetverikov I tweaked your change a bit here to return an empty name when constructor.name is empty since that would seem to be the expected behavior for anonymous classes like new (class {}).
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6360 with an added spec.
Use
''as thenamewhen the object argument has no constructor. This makes the behavior for arguments the same as the behavior of return values.Refs #5736
Closes #6360