Bound the target width and height of window when calling SetSize #6363
Conversation
e72ce7a to
c81699c
Compare
|
Doing this in |
|
@zcbenz Was just writing up a comment querying if that would be the case 😆 I'll quickly transpose this into the mac native window file. 👍 |
|
🎉 Magic 😆 It's now in native window mac 👍 |
| @@ -756,6 +756,17 @@ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val, | |||
| return bounds; | |||
| } | |||
|
|
|||
| void NativeWindowMac::SetSize(const gfx::Size& size, bool animate) { | |||
There was a problem hiding this comment.
All size APIs are directly to the SetBounds method, so we only need to do check there.
| bSize.SetToMax(GetMinimumSize()); | ||
|
|
||
| gfx::Size maxSize = GetMaximumSize(); | ||
| maxSize = gfx::Size(maxSize.width() == 0 ? bSize.width() : maxSize.width(), |
There was a problem hiding this comment.
We couldn't use a straight up SetToMin call here as for some reason Electron's default maximumSize is [0, 0]. This means we need these nasty ternary operatorst
|
🎉 Magic 😆 It's now in SetBounds 👍 |
|
👍 |
This fixes #6347 by bounding the width and height values by the MinimumSize and MaximumSize bounds of the window.