8000 Set maximizable state after installing view by kevinsawicki · Pull Request #5944 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set maximizable state after installing view #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2016
Merged

Set maximizable state after installing view #5944

merged 1 commit into from
Jun 9, 2016

Conversation

kevinsawicki
Copy link
Contributor
@kevinsawicki kevinsawicki commented Jun 8, 2016 •
edited
Loading

Looks like the call to setWantsLayer on a transparent window with a frame in InstallView was causing the zoom button state to get reset so the previous call to SetMaximizable was getting undone.

This sets the maximizable state after InstallView() is called which appears to resolve this issue.

window = new BrowserWindow({
    show: true,
    width: 800,
    height: 800,
    transparent: true,
    maximizable: false,
    backgroundColor: '#fff',
})

Before

screen shot 2016-06-08 at 2 02 33 pm

### After

screen shot 2016-06-08 at 2 01 14 pm

@zcbenz you mentioned in #5745 (comment) that transparent windows with frames weren't really supported but it might be okay to address if the fix was small and it does seem pretty small, but I'm also fine closing this out if this issue isn't worth addressing.

Closes #5745

@kevinsawicki
Copy link
Contributor Author
kevinsawicki commented Jun 8, 2016 •
edited
Loading

This does seem to also address the case @danhp mentioned in #5745 (comment) as well:

mainWindow = new BrowserWindow({
  width: 800,
  height: 600,
  titleBarStyle: 'hidden',
  minimizable: false,
  maximizable: false
});

screen shot 2016-06-08 at 2 06 26 pm

@zcbenz
Copy link
Contributor
zcbenz commented Jun 9, 2016

👍

@zcbenz zcbenz merged commit 0abd552 into master Jun 9, 2016
@zcbenz zcbenz deleted the set-maximizable-last branch June 9, 2016 01:52
@luclu luclu mentioned this pull request Jun 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't disable maximizable gumdrop with frameless windows
2 participants
@kevinsawicki @zcbenz
0