8000 fix: do not load source for `electron` module in ESM loader synchronous flow by trop[bot] · Pull Request #47342 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: do not load source for electron module in ESM loader synchronous flow #47342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

fix: do not load source for electron module in ESM loader synchronous flow #47342

merged 2 commits into from
Jun 5, 2025

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jun 3, 2025

Backport of #46810

See that PR for details.

Notes: Fixed an error when importing electron for the first time from an ESM module loaded by a CJS module in a packaged app.

@trop @clavin
fix: do not load electron from ESM loader's CJS compatibility
0a2560e 
Co-authored-by: clavin <clavin@electronjs.org>
8000 @trop trop bot requested a review from a team as a code owner June 3, 2025 10:50
@trop trop bot requested review from clavin and a team June 3, 2025 10:50
@trop trop bot mentioned this pull request Jun 3, 2025
Merged
5 tasks
@trop trop bot added 37-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 3, 2025
@codebytere codebytere merged commit 380351c into 37-x-y Jun 5, 2025
97 of 100 checks passed
@codebytere codebytere deleted the trop/37-x-y-bp-fix-do-not-load-source-for-electron-module-in-esm-loader-synchronous-flow-1748947825487 branch June 5, 2025 08:04
@release-clerk
Copy link
release-clerk bot commented Jun 5, 2025

Release Notes Persisted

Fixed an error when importing electron for the first time from an ESM module loaded by a CJS module in a packaged app.

@jkleinsc jkleinsc mentioned this pull request Jun 5, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@clavin clavin Awaiting requested review from clavin

Assignees
No one assigned
Labels
37-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @clavin
0