refactor: extract-constant static Windows registry keys in Browser code #47569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termination clearer
ckerr
commented
Jun 25, 2025
| HKEY hkey; | ||
| // StartupApproved registry path | ||
| LPCTSTR path = TEXT( | ||
| "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Explorer\\StartupApp" |
There was a problem hiding this comment.
Note: keys are case-insensitive. The old value of SOFTWARE\Foo\Bar here is inconsistent with the other code in the file that used Software\Foo\Bar instead, but it's functionally equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
browser_win.cchas a lot of redundant declarations of Windows registry keys. This PR makes symbolic constants for them and uses those instead. The symbolic constants are declared as constexpr base::wcstring_view to avoid the need forstd::wstringtemporaries.Checklist
npm testpassesRelease Notes
Notes: none.