8000 refactor: make context bridge's private keys hidden, constexpr string_views by ckerr · Pull Request #47562 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: make context bridge's private keys hidden, constexpr string_views #47562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: make context bridge's private keys hidden, constexpr string_views #47562

wants to merge 4 commits into from
+20 −25

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Jun 25, 2025

Description of Change

A small cleanup/correctness PR for ContextBridge, which accidentally put its private look 8000 up keys in a public namespace.

This PR moves them into a private namespace and changes their type to constexpr std::string_view.

Checklist

Release Notes

Notes: none.

@ckerr ckerr added semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jun 25, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 25, 2025
dcq01

This comment was marked as spam.

Sign in to view

@ckerr

This comment was marked as resolved.

Sign in to view
@ckerr ckerr force-pushed the refactor/make-context-bridge-keys-string-views branch from 96b9084 to f249768 Compare June 26, 2025 13:20
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcq01 dcq01 dcq01 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckerr @dcq01
0