8000 fix: ensure `/dev/null` fd is closed on failure by trop[bot] · Pull Request #47542 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ensure /dev/null fd is closed on failure #47542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

fix: ensure /dev/null fd is closed on failure #47542

merged 2 commits into from
Jun 24, 2025
+3 −0

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jun 24, 2025

Backport of #47525

See that PR for details.

Notes: Fixed an issue where utility processes could leak file handles.

trop bot and others added 2 commits June 24, 2025 15:45
@trop @codebytere
fix: ensure /dev/null fd is closed on failure
d08ddc3 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop @deepak1556
chore: ignore closehandle for windows
8ddeb2c 
Co-authored-by: Robo <hop2deep@gmail.com>
@trop trop bot requested review from codebytere and a team June 24, 2025 15:45
@trop trop bot mentioned this pull request Jun 24, 2025
Merged
3 tasks
@trop trop bot added 35-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 24, 2025
@codebytere codebytere merged commit 12be909 into 35-x-y Jun 24, 2025
61 checks passed
@codebytere codebytere deleted the trop/35-x-y-bp-fix-ensure-dev-null-fd-is-closed-on-failure-1750779898443 branch June 24, 2025 19:12
@release-clerk
Copy link
release-clerk bot commented Jun 24, 2025

Release Notes Persisted

Fixed an issue where utility processes could leak file handles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
64FA
Reviewers

@nikwen nikwen nikwen approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
35-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikwen @codebytere
0