8000 fix: set `XDG_CURRENT_DESKTOP` env var back to original value before invoking xdg utils by trop[bot] · Pull Request #46789 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set XDG_CURRENT_DESKTOP env var back to original value before invoking xdg utils #46789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: set XDG_CURRENT_DESKTOP env var back to original value before invoking xdg utils #46789

merged 1 commit into from
Apr 25, 2025
+9 −0

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 25, 2025

Backport of #45310

See that PR for details.

Notes: Fixed electron.shell.openExternal and electron.shell.openPath to honor user-defined system defaults on Linux

@trop @esimkowitz
fix: set XDG_CURRENT_DESKTOP env var back to original value before …
2ba6252 
…invoking xdg utils (#45310)

* Fix XDG_CURRENT_DESKTOP before invoking XDGUtil

* apply suggestion

* use existing XDG_CURRENT_DESKTOP const

Co-authored-by: Evan Simkowitz <esimkowitz@users.noreply.github.com>
@trop trop bot requested a review from a team April 25, 2025 16:32
@trop trop bot mentioned this pull request Apr 25, 2025
Merged
2 tasks
@trop trop bot added 35-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 25, 2025
@ckerr ckerr merged commit 96db57f into 35-x-y Apr 25, 2025
60 checks passed
@ckerr ckerr deleted the trop/35-x-y-bp-fix-set-xdg_current_desktop-env-var-back-to-original-value-before-invoking-xdg-utils-1745598707860 branch April 25, 2025 20:23
@release-clerk
Copy link
release-clerk bot commented Apr 25, 2025

Release Notes Persisted

Fixed electron.shell.openExternal and electron.shell.openPath to honor user-defined system defaults on Linux

@daiyam daiyam mentioned this pull request May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
35-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ckerr
0