8000 docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse by nikwen · Pull Request #44680 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse #44680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse #44680

merged 1 commit into from
Nov 18, 2024

Conversation

nikwen
Copy link
Member
@nikwen nikwen commented Nov 15, 2024

Fixes #44450

Description of Change

The fuse was added in #35266. It's currently not obvious from the documentation why someone would use it.

Further reading: https://gitnation.com/contents/nodejs-startup-snapshots

Thanks to @codebytere for the pointer!

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels Nov 15, 2024
@nikwen nikwen force-pushed the document-loadBrowserProcessSpecificV8Snapshot branch from 0a44121 to d5d25c3 Compare November 15, 2024 15:26
@nikwen nikwen force-pushed the document-loadBrowserProcessSpecificV8Snapshot branch from d5d25c3 to 508f90b Compare November 15, 2024 16:03
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 16, 2024
@codebytere codebytere requested a review from a team November 18, 2024 10:14
@erickzhao erickzhao added target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. labels Nov 18, 2024
erickzhao
erickzhao approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member
@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer bot approved these changes Nov 18, 2024
View reviewed changes
Copy link
@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@VerteDinde VerteDinde merged commit aa7a5e6 into electron:main Nov 18, 2024
28 checks passed
@release-clerk
Copy link
release-clerk bot commented Nov 18, 2024

No Release Notes

This was referenced Nov 18, 2024
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Nov 18, 2024

I have automatically backported this PR to "34-x-y", please check out #44709

@trop trop bot added in-flight/34-x-y and removed target/34-x-y PR should also be added to the "34-x-y" branch. labels Nov 18, 2024
@trop
Copy link
Contributor
trop bot commented Nov 18, 2024

I have automatically backported this PR to "33-x-y", please check out #44710

@trop trop bot added in-flight/33-x-y and removed target/33-x-y PR should also be added to the "33-x-y" branch. labels Nov 18, 2024
@nikwen
Copy link
Member Author
nikwen commented Nov 18, 2024

Thanks, everyone, for the reviews and for merging! 🙌

@trop trop bot added merged/33-x-y PR was merged to the "33-x-y" branch. and removed in-flight/33-x-y in-flight/34-x-y labels Nov 18, 2024
@trop trop bot added the merged/34-x-y PR was merged to the "34-x-y" branch. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

@erickzhao erickzhao erickzhao approved these changes

@erikian erikian erikian approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer[bot] approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation request] Explain why someone might enable the fuse loadBrowserProcessSpecificV8Snapshot
6 participants
@nikwen @ckerr @codebytere @erickzhao @erikian @VerteDinde
0