8000 fix: crash on macOS non-programmatic close by codebytere · Pull Request #41264 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash on macOS non-programmatic close #41264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix: crash on macOS non-programmatic close #41264

merged 1 commit into from
Feb 9, 2024

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Feb 7, 2024 •
edited
Loading

Description of Change

Closes #40798
Refs microsoft/vscode#204563

Fixes a crash that started occurring sporadically with some types of macOS window close after PartitionAlloc was enabled upstream. It seems to be the case now that performClose: can cause window_ to be null, thus causing the call to IsVisible to crash trying to access a deallocated instance. There's probably more effective long-term fix here but we can fix this by moving the conditional determining whether we should call NotifyWindowCloseButtonClicked() for a closed sheet above performClosure to avoid this problem altogether.

Using the Cmd+Tab -> Cmd+Q repro provided in #40798 I tracked this back to v28.0.0-alpha.3...v28.0.0-alpha.4 - specifically reverting #33981 fixes the issue as well so we should investigate that further as a follow up.

h/t @MarshallOfSound for speculating this fix in response to what might be the same issue in Discord.

cc @deepak1556 @bpasero

Checklist

Release Notes

Notes: Fixed a crash that started occurring sporadically with some types of macOS window close

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 7, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 7, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 8, 2024
@codebytere
Copy link
Member Author

Unrelated WOA failures due to occlusion tests.

@codebytere codebytere merged commit c894645 into main Feb 9, 2024
@codebytere codebytere deleted the fix-crash-on-close branch February 9, 2024 21:44
@release-clerk
Copy link
release-clerk bot commented Feb 9, 2024

Release Notes Persisted

Fixed a crash that started occurring sporadically with some types of macOS window close

This was referenced Feb 9, 2024
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Feb 9, 2024

I have automatically backported this PR to "28-x-y", please check out #41298

@trop trop bot added in-flight/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Feb 9, 2024
@trop
Copy link
Contributor
trop bot commented Feb 9, 2024

I have automatically backported this PR to "29-x-y", please check out #41299

@trop trop bot added in-flight/29-x-y merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/28-x-y in-flight/29-x-y labels Feb 9, 2024
@JellyBrick JellyBrick mentioned this pull request Feb 18, 2024
Closed
5 tasks
@codebytere codebytere mentioned this pull request Feb 19, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Segfault when closing the app on macOS (v28)
5 participants
@codebytere @ckerr @zcbenz @deepak1556 @VerteDinde
0