8000 docs: add note about fuses to our security documentation by Kilian · Pull Request #41210 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add note about fuses to our security documentation #41210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2024
Merged

docs: add note about fuses to our security documentation #41210

merged 4 commits into from
Feb 2, 2024

Conversation

Kilian
Copy link
Member
@Kilian Kilian commented Feb 1, 2024

Description of Change

This adds a new item to the security checklist to review the fuses values. IT also adds item number 18 to the ToC up top.

Checklist

Release Notes

Notes: none

@Kilian
Add note about fuses to our security documentation
be261a6 
Additionally, add the missing electron#18 to the ToC.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 1, 2024
@Kilian Kilian changed the title documentation: add note about fuses to our security documentation docs: add note about fuses to our security documentation Feb 1, 2024
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Feb 1, 2024
@Kilian Kilian requested a review from a team February 1, 2024 15:37
felixrieseberg
felixrieseberg approved these changes Feb 1, 2024
View reviewed changes
erickzhao
erickzhao approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member
@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer bot approved these changes Feb 1, 2024
View reviewed changes
Copy link
@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@erickzhao erickzhao added target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 1, 2024
dsanders11
dsanders11 requested changes Feb 1, 2024
View reviewed changes
Copy link
Member
@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the new section above the reference link definitions so they stay at the bottom of the doc?

Kilian and others added 2 commits February 2, 2024 08:38
@Kilian
Copy link
Member Author
Kilian commented Feb 2, 2024

@dsanders11 change made!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 2, 2024
@ckerr ckerr merged commit 3ec04fd into electron:main Feb 2, 2024
@release-clerk
Copy link
release-clerk bot commented Feb 2, 2024

No Release Notes

@trop
Copy link
Contributor
trop bot commented Feb 2, 2024

I was unable to backport this PR to "28-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/28-x-y and removed target/28-x-y PR should also be added to the "28-x-y" branch. labels Feb 2, 2024
trop bot added a commit that referenced this pull request Feb 2, 2024
@trop @Kilian
docs: add note about fuses to our security documentation (#41210)
092585c 
* Add note about fuses to our security documentation

Additionally, add the missing #18 to the ToC.

* lint issues for security.md

* Update docs/tutorial/security.md

Co-authored-by: Felix Rieseberg <fr@makenotion.com>

* move reference links to bottom of security.md

---------

Co-authored-by: Felix Rieseberg <fr@makenotion.com>

Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
@trop trop bot mentioned this pull request Feb 2, 2024
Merged
@trop
Copy link
Contributor
trop bot commented Feb 2, 2024

I have automatically backported this PR to "29-x-y", please check out #41227

@trop trop bot added in-flight/29-x-y and removed target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 2, 2024
ckerr pushed a commit that referenced this pull request Feb 3, 2024
@trop @Kilian
docs: add note about fuses to our security documentation (#41227)
d5b0df6 
docs: add note about fuses to our security documentation (#41210)

* Add note about fuses to our security documentation

Additionally, add the missing #18 to the ToC.

* lint issues for security.md

* Update docs/tutorial/security.md



* move reference links to bottom of security.md

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kilian Valkhof <kilian@kilianvalkhof.com>
@trop trop bot added merged/29-x-y PR was merged to the "29-x-y" branch. and removed in-flight/29-x-y labels 8475 Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixrieseberg felixrieseberg felixrieseberg approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@erickzhao erickzhao erickzhao approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer[bot] approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/29-x-y PR was merged to the "29-x-y" branch. needs-manual-bp/28-x-y semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kilian @felixrieseberg @dsanders11 @erickzhao @ckerr
0