8000 fix: allow setsize to be called within a move or resize for preventDefault by trop[bot] · Pull Request #35082 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: allow setsize to be called within a move or resize for preventDefault #35082

New is 8000 sue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix: allow setsize to be called within a move or resize for preventDefault #35082

merged 1 commit into from
Aug 3, 2022

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jul 27, 2022

Backport of #34843

See that PR for details.

Notes: Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 27, 2022
@trop trop bot mentioned this pull request Jul 27, 2022
Merged
2 tasks
@trop trop bot added 18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 27, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 27, 2022
@codebytere codebytere merged commit b990bd6 into 18-x-y Aug 3, 2022
@codebytere codebytere deleted the trop/18-x-y-bp-fix-allow-setsize-to-be-called-within-a-move-or-resize-for-preventdefault-1658880145504 branch August 3, 2022 09:55
@release-clerk
Copy link
release-clerk bot commented Aug 3, 2022

Release Notes Persisted

Fixed an issue in which calling setBounds() after e.preventDefault in a 'will-move' or 'will-resize' event wouldn't change the window's shape until the mouse button was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
18-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @mesner
0