8000 fix: crash on startup in X11 by ckerr · Pull Request #35075 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash on startup in X11 #35075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix: crash on startup in X11 #35075

merged 1 commit into from
Jul 27, 2022

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Jul 26, 2022

Description of Change

Fixes #34996.

This is a regression introduced in 20.0.0-beta.9 caused by ElectronBrowserMainParts::PreCreateThreads() creating the main window before loading the locale resource bundle, but ui::BuildDisplaysFromXRandRInfo() needed that locale info to be loaded.

CC @electron/wg-releases

Checklist

Release Notes

Notes: Fix 20.0.0-beta.8 X11 crash regression.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 26, 2022
VerteDinde
VerteDinde approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member
@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙌 Tested on Fedora with X11, crash is no longer happening

@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Jul 26, 2022
@deepak1556
Copy link
Member
8000 deepak1556 commented Jul 27, 2022

Failing test is unrelated, merging.

@deepak1556 deepak1556 merged commit 62001dc into main Jul 27, 2022
@deepak1556 deepak1556 deleted the fix/34996-regression-crash-on-startup-in-Xorg-on-20.0.0-beta.9 branch July 27, 2022 04:44
@release-clerk
Copy link
release-clerk bot commented Jul 27, 2022

Release Notes Persisted

Fix 20.0.0-beta.8 X11 crash regression.

@trop trop bot mentioned this pull request Jul 27, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Jul 27, 2022

I have automatically backported this PR to "20-x-y", please check out #35092

@commit-lint commit-lint bot mentioned this pull request Oct 4, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@ckerr @schetle
fix: crash on startup in X11 (electron#35075)
8882d03 
Fixes electron#34996.
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@ckerr @khalwa
fix: crash on startup in X11 (electron#35075)
570fb77 
Fixes electron#34996.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened recently semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SIGTRAP when starting electron >= 20.0.0-beta.9
5 participants
@ckerr @deepak1556 @zcbenz @codebytere @VerteDinde
0