8000 docs: update bluetooth fiddle example event name to trigger correct event by sammyl720 · Pull Request #35894 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: update bluetooth fiddle example event name to trigger correct event #35894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2022
Merged

docs: update bluetooth fiddle example event name to trigger correct event #35894

merged 3 commits into from
Oct 4, 2022

Conversation

sammyl720
Copy link
Contributor
@sammyl720 sammyl720 commented Oct 4, 2022 •
edited by VerteDinde
Loading

Description of Change

Fix the spelling of the event name in the bluetooth example fiddle preload.js file so that the correct event get triggered.

Checklist

Release Notes

Notes: Fixed spelling in bluetooth example documentation

@welcome
Copy link
welcome bot commented Oct 4, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 4, 2022
@sammyl720 sammyl720 changed the title Fix bluetooth example fiddle spelling fix: update bluetooth fiddle example event name to trigger correct event Oct 4, 2022
@VerteDinde VerteDinde changed the title fix: update bluetooth fiddle example event name to trigger correct event docs: update bluetooth fiddle example event name to trigger correct event Oct 4, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Oct 4, 2022
@erickzhao erickzhao added target/20-x-y target/21-x-y PR should also be added to the "21-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. and removed target/20-x-y labels Oct 4, 2022
jkleinsc
jkleinsc approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sammyl720!

@jkleinsc jkleinsc merged commit ff0517b into electron:main Oct 4, 2022
@welcome
Copy link
welcome bot commented Oct 4, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link
release-clerk bot commented Oct 4, 2022

Release Notes Persisted

Fixed spelling in bluetooth example documentation

@trop trop bot mentioned this pull request Oct 4, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Oct 4, 2022

I have automatically backported this PR to "21-x-y", please check out #35907

@trop trop bot added the in-flight/21-x-y label Oct 4, 2022
@trop trop bot mentioned this pull request Oct 4, 2022
Merged
@trop trop bot removed the target/21-x-y PR should also be added to the "21-x-y" branch. label Oct 4, 2022
@trop
Copy link
Contributor
trop bot commented Oct 4, 2022

I have automatically backported this PR to "22-x-y", please check out #35908

@trop trop bot added in-flight/22-x-y merged/22-x-y PR was merged to the "22-x-y" branch. merged/21-x-y PR was merged to the "21-x-y" branch. and removed target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/22-x-y labels Oct 4, 2022
@commit-lint commit-lint bot mentioned this pull request Jan 31, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@sammyl720 828B @khalwa
docs: update bluetooth fiddle example event name to trigger correct e…
4aa5c21 
…vent (electron#35894)

* Fix event type spelling for bluetooth fiddle example

* docs: Fix event type spelling for bluetooth documentation fiddle example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/21-x-y PR was merged to the "21-x-y" branch. merged/22-x-y PR was merged to the "22-x-y" branch. new-pr 🌱 PR opened recently semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammyl720 @jkleinsc @erickzhao
0