-
Notifications
You must be signed in to change notification settings - Fork 16.2k
fix: ensure mas builds of the same application can use safestorage #35864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that MAS builds of applications with an equivilant darwin build that share the same name do not fight over access to the same Safe Storage account. Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron. We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on. Existin 8000 g apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the safestorage key as during the migration we delete the old account. This is an acceptable edge case as no one should be actively using two versions of the same app.
deepak1556
reviewed
Oct 3, 2022
patches/chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Show resolved
Hide resolved
deepak1556
reviewed
Oct 3, 2022
patches/chromium/feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
Show resolved
Hide resolved
deepak1556
approved these changes
<
8000
span class="color-fg-muted">
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
VerteDinde
approved these changes
Oct 3, 2022
Release Notes Persisted
|
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…lectron#35864) feat: ensure mas builds of the same application can use safestorage This change ensures that MAS builds of applications with an equivilant darwin build that share the same name do not fight over access to the same Safe Storage account. Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron. We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on. Existing apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the safestorage key as during the migration we delete the old account. This is an acceptable edge case as no one should be actively using two versions of the same app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that MAS builds of applications with an equivalent darwin build that share the same name do not fight over access to the same Safe Storage account.
Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron.
We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on.
Existing apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the SafeStorage key as during the migration we delete the old account. This is an acceptable edge case as no one should be actively using two versions of the same app and I don't think should be classified as a breaking change because this scenario didn't work before anyway (due to conflicting IAM access to the same keychain item)
Notes: The keychain account name for MAS and Darwin builds of the same Electron application now differ