8000 fix: ensure mas builds of the same application can use safestorage by MarshallOfSound · Pull Request #35864 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ensure mas builds of the same application can use safestorage #35864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

MarshallOfSound
Copy link
Member

This change ensures that MAS builds of applications with an equivalent darwin build that share the same name do not fight over access to the same Safe Storage account.

Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron.

We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on.

Existing apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the SafeStorage key as during the migration we delete the old account. This is an acceptable edge case as no one should be actively using two versions of the same app and I don't think should be classified as a breaking change because this scenario didn't work before anyway (due to conflicting IAM access to the same keychain item)

Notes: The keychain account name for MAS and Darwin builds of the same Electron application now differ

This change ensures that MAS builds of applications with an equivilant darwin build that share the same name do not fight over access to the same Safe Storage account.

Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron.

We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on.

Existin
8000
g apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the safestorage key as during the migration we delete the old account.  This is an acceptable edge case as no one should be actively using two versions of the same app.
@MarshallOfSound MarshallOfSound requested a review from a team as a code owner September 30, 2022 00:17
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 30, 2022
@MarshallOfSound MarshallOfSound changed the title feat: ensure mas builds of the same application can use safestorage fix: ensure mas builds of the same application can use safestorage Sep 30, 2022
@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Sep 30, 2022
@MarshallOfSound MarshallOfSound requested a review from a team September 30, 2022 00:52
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 1, 2022
deepak1556
deepak1556 approved these changes < 8000 span class="color-fg-muted"> Oct 3, 2022
Copy link
Member
@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarshallOfSound MarshallOfSound merged commit 2cda144 into main Oct 4, 2022
@MarshallOfSound MarshallOfSound deleted the split-keys-mas-ddl branch October 4, 2022 06:36
@release-clerk
Copy link
release-clerk bot commented Oct 4, 2022

Release Notes Persisted

The keychain account name for MAS and Darwin builds of the same Electron application now differ

khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
…lectron#35864)

feat: ensure mas builds of the same application can use safestorage

This change ensures that MAS builds of applications with an equivilant darwin build that share the same name do not fight over access to the same Safe Storage account.

Specifically this changes the account name for app "My App" from "My App" to "My App AppStore" if the app is using a MAS build of Electron.

We attempt to migrate the safe storage key from the old account, if that migration succeeds we delete the old key and move on.

Existing apps that aren't built for the app store should be unimpacted, there is one edge case where a user uses BOTH an AppStore and a darwin build of the same app only one will keep it's access to the safestorage key as during the migration we delete the old account.  This is an acceptable edge case as no one should be actively using two versions of the same app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0