8000 docs: add performance advice to disable default menu creation by bpasero · Pull Request #35525 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add performance advice to disable default menu creation #35525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2022
Merged

docs: add performance advice to disable default menu creation #35525

merged 3 commits into from
Sep 12, 2022

Conversation

bpasero
Copy link
Contributor
@bpasero bpasero commented Aug 31, 2022 •
edited
Loading

Description of Change

Fixes #35512

Checklist

Release Notes

Notes: docs: add performance advice to disable default menu creation

@welcome
Copy link
welcome bot commented Aug 31, 2022

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 31, 2022
@bpasero bpasero changed the title Mention the trick to disable default menu docs: mention the trick to disable default menu Aug 31, 2022
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes labels Aug 31, 2022
@bpasero bpasero mentioned this pull request Aug 31, 2022
Closed
3 tasks
@deepak1556 deepak1556 added semver/none no-backport and removed semver/patch backwards-compatible bug fixes labels Aug 31, 2022
MarshallOfSound
MarshallOfSound reviewed Aug 31, 2022
View reviewed changes
@bpasero bpasero changed the title docs: mention the trick to disable default menu docs: add performance advice to disable default menu creation Sep 1, 2022
@electron-cation electron-cation bot added the semver/patch backwards-compatible bug fixes label Sep 1, 2022
@bpasero
Copy link
Contributor Author
bpasero commented Sep 1, 2022

This is good to go now, I made the text a bit more verbose and easier to read.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 1, 2022
@codebytere
Copy link
Member

Lint failure:

docs/tutorial/performance.md:424:76 MD009/no-trailing-spaces Trailing spaces [Expected: 0; Actual: 1]
docs/tutorial/performance.md:430:74 MD009/no-trailing-spaces Trailing spaces [Expected: 0; Actual: 1]

@ckerr
Copy link
Member
ckerr commented Sep 12, 2022 •
edited
Loading

Invo 8000 ke-RestMethod : {"message":"Artifact not found or access denied."}

CI failure appears to be unrelated to the PR and we've got three approvals, so I'm going to merge this.

@nornagon nornagon removed the semver/patch backwards-compatible bug fixes label Sep 12, 2022
@nornagon
Copy link
Contributor

It's a little surprising that this is so expensive! Is there any way we can work around this technically?

@ckerr ckerr merged commit 6ec4c7e into electron:main Sep 12, 2022
@release-clerk
Copy link
release-clerk bot commented Sep 12, 2022

Release Notes Persisted

docs: add performance advice to disable default menu creation

@bpasero bpasero deleted the patch-1 branch September 13, 2022 03:57
@commit-lint commit-lint bot mentioned this pull request Jan 2, 2023
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@bpasero @khalwa
docs: add performance advice to disable default menu creation (electr…
d457fc1 
…on#35525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@ckerr ckerr ckerr approved these changes

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
5613 documentation 📓 no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: electron should not set a default menu
7 participants
@bpasero @codebytere @ckerr @nornagon @zcbenz @MarshallOfSound @deepak1556
0