fix: esc not working on Windows during fullscreen #34317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
approved these changes
May 23, 2022
zcbenz
approved these changes
May 24, 2022
|
WOA failure is unrelated |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "18-x-y" cleanly; |
|
I was unable to backport this PR to "19-x-y" cleanly; |
|
@codebytere has manually backported this PR to "19-x-y", please check out #34359 |
|
@codebytere has manually backported this PR to "18-x-y", please check out #34361 |
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
* fix: esc not working on Windows during fullscreen * chore: fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34301.
Cleans up fullscreen control logic cross-platform.
fullscreen_controller()->EnterFullscreenModeForTabinWebContents::EnterFullscreenModeForTab, becuase there's a chance that the user will deny permission viasession.setPermissionRequestHandler. Only call this inOnlyEnterFullscreenModeForTabafter the user has allowed fullscreening.NotifyExclusiveTabAccessLostis called on all platforms inFullscreenController::ExitFullscreenModeInternal()and not just macOS, since Electron's native window impls report state change fairly instantly as well, and so pressing escape won't work on Linux or Windows to un-fullscreen in some circumstances without this change.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where pressing escape would not un-fullscreen on Windows or Linux in some circumstances.