8000 fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow by VerteDinde · Pull Request #34295 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: revert "feat: add first-instance-ack event to the app.requestSingleInstanceLock() flow #34295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2022
Merged

fix: revert "feat: add first-instance-ack event to the app.requestSingleInstanceLock() flow #34295

merged 3 commits into from
May 23, 2022

Conversation

VerteDinde
Copy link
Member
@VerteDinde VerteDinde commented May 19, 2022 •
edited
Loading

Manual backport of #34297

See that PR for details

Notes: Fixed an issue where running second instances of the same application would cause a deadlock on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 19, 2022
@VerteDinde VerteDinde force-pushed the revert-ackpipe-18-x-y branch from 26c41f3 to 9d6df29 Compare May 19, 2022 20:41
@VerteDinde VerteDinde added backport-check-skip Skip trop's backport validity checking 18-x-y labels May 19, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 19, 2022
@VerteDinde VerteDinde added the semver/minor backwards-compatible functionality label May 19, 2022
@VerteDinde VerteDinde force-pushed the revert-ackpipe-18-x-y branch from 9d6df29 to 0039997 Compare May 19, 2022 22:46
@VerteDinde VerteDinde force-pushed the revert-ackpipe-18-x-y branch from 0039997 to 0225b19 Compare May 20, 2022 00:32
@trop trop bot mentioned this pull request May 20, 2022
Merged
5 tasks
@VerteDinde VerteDinde marked this pull request as ready for review May 20, 2022 00:33
@VerteDinde VerteDinde requested review from a team as code owners May 20, 2022 00:33
@VerteDinde VerteDinde merged commit fbc398f into 18-x-y May 23, 2022
@VerteDinde VerteDinde deleted the revert-ackpipe-18-x-y branch May 23, 2022 05:22
@release-clerk
Copy link
release-clerk bot commented May 23, 2022

Release Notes Persisted

Fixed an issue where running second instances of the same application would cause a deadlock on Windows.

VerteDinde added a commit that referenced this pull request May 23, 2022
@VerteDinde
fix: revert "feat: add first-instance-ack event to the `app.requestSi…
6ae0a22 
…ngleInstanceLock()` flow (#34295)

* Revert "fix: requestSingleInstanceLock API ConnectNamedPipe sometimes hangs program (#33778)"

This reverts commit ffb8749.

* fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow"

* chore: update patch
codebytere pushed a commit that referenced this pull request May 23, 2022
@VerteDinde
8307
revert: add first-instance-ack event to the app.requestSingleInstance…
23c18be 
…Lock() flow (#34312)

fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow (#34295)

* Revert "fix: requestSingleInstanceLock API ConnectNamedPipe sometimes hangs program (#33778)"

This reverts commit ffb8749.

* fix: revert "feat: add first-instance-ack event to the `app.requestSingleInstanceLock()` flow"

* chore: update patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
18-x-y backport-check-skip Skip trop's backport validity checking semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VerteDinde @deepak1556 @codebytere
0