8000 fix: draggable regions updating on bounds change by codebytere · Pull Request #34582 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: draggable regions updating on bounds change #34582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

fix: draggable regions updating on bounds change #34582

merged 1 commit into from
Jun 17, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #34552.

Fixes an issue where draggable regions were not recalculated when BrowserView bounds changed. This was happening because we didn't issue a call to UpdateDraggableRegions after bounds changed on Windows, as we do on macOS:

electron/shell/browser/native_browser_view_mac.mm

Line 270 in abf6f1c

UpdateDraggableRegions(draggable_regions_);

Checklist

Release Notes

Notes: Fixed an issue where draggable regions were not recalculated when BrowserView bounds changed on Windows.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/18-x-y labels Jun 15, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 15, 2022
zcbenz
zcbenz reviewed Jun 16, 2022
View reviewed changes
@codebytere codebytere requested a review from zcbenz June 16, 2022 10:25
@codebytere codebytere force-pushed the draggable-regions-move-windows branch from c23201d to f01c720 Compare June 16, 2022 10:25
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 16, 2022
@codebytere codebytere merged commit 20538c4 into main Jun 17, 2022
@codebytere codebytere deleted the draggable-regions-move-windows branch June 17, 2022 10:01
@release-clerk
Copy link
release-clerk bot commented Jun 17, 2022

Release Notes Persisted

Fixed an issue where draggable regions were not recalculated when BrowserView bounds changed on Windows.

This was referenced Jun 17, 2022
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Jun 17, 2022

I have automatically backported this PR to "18-x-y", please check out #34610

@trop trop bot mentioned this pull request Jun 17, 2022
Merged
@trop trop bot removed the target/18-x-y label Jun 17, 2022
@trop
Copy link
Contributor
trop bot commented Jun 17, 2022

I have automatically backported this PR to "19-x-y", please check out #34611

@trop
Copy link
Contributor
trop bot commented Jun 17, 2022

I have automatically backported this PR to "20-x-y", please check out #34612

@commit-lint commit-lint bot mentioned this pull request Aug 18, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: draggable regions updating on bounds change (electron#34582)
6b3be17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@VerteDinde VerteDinde Awaiting requested review from VerteDinde

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: -webkit-app-region not recalculated when BrowserView bounds changed
2 participants
@codebytere @zcbenz
0