8000 fix: iocp integration when process is reused by deepak1556 · Pull Request #33207 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: iocp integration when process is reused #33207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2022
Merged

fix: iocp integration when process is reused #33207

merged 1 commit into from
Mar 21, 2022

Conversation

deepak1556
Copy link
Member
@deepak1556 deepak1556 commented Mar 9, 2022 •
edited
Loading

Description of Change

Fixes #1968
Fixes #30153

Refs microsoft/vscode#142786 (comment)

Checklist

Release Notes

Notes: fix broken event loop in renderer process when process reuse is enabled on windows platform

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 9, 2022
@deepak1556 deepak1556 requested a review from zcbenz March 9, 2022 02:43
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/16-x-y labels Mar 9, 2022
@deepak1556 deepak1556 force-pushed the robo/fix_iocp_integration branch from 7aa2af9 to 9b696d6 Compare March 9, 2022 03:55
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 10, 2022
@zcbenz zcbenz force-pushed the robo/fix_iocp_integration branch from f193ed9 to 6d2c9c7 Compare March 21, 2022 03:55
@zcbenz zcbenz merged commit 4cc2ed8 into main Mar 21, 2022
@zcbenz zcbenz deleted the robo/fix_iocp_integration branch March 21, 2022 07:42
@release-clerk
Copy link
release-clerk bot commented Mar 21, 2022

Release Notes Persisted

fix broken event loop in renderer process when process reuse is enabled on windows platform

@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/16-x-y label Mar 21, 2022
@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

I was unable to backport this PR to "18-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/15-x-y label Mar 21, 2022
@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

deepak1556 added a commit that referenced this pull request Mar 21, 2022
@deepak1556
fix: iocp integration when process is reused (#33207)
5a0b028
@deepak1556 deepak1556 mentioned this pull request Mar 21, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

@deepak1556 has manually backported this PR to "18-x-y", please check out #33361

deepak1556 added a commit that referenced this pull request Mar 21, 2022
@deepak1556
fix: iocp integration when process is reused (#33207)
529aa11
@deepak1556 deepak1556 mentioned this pull request Mar 21, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

@deepak1556 has manually backported this PR to "17-x-y", please check out #33362

deepak1556 added a commit that referenced this pull request Mar 21, 2022
@deepak1556
fix: iocp integration when process is reused (#33207)
8f25662
@deepak1556 deepak1556 mentioned this pull request Mar 21, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Mar 21, 2022

@deepak1556 has manually backported this PR to "16-x-y", please check out #33363

deepak1556 added a commit that referenced this pull request Mar 21, 2022
@deepak1556
fix: iocp integration when process is reused (#33207)
7f0f18d
deepak1556 added a commit that referenced this pull request Mar 21, 2022
@deepak1556
fix: iocp integration when process is reused (#33207) (#33361)
a327684
jkleinsc pushed a commit that referenced this pull request Mar 21, 2022
@deepak1556
fix: iocp integration when process is reused (#33207) (#33362)
aca1e8e
deepak1556 added a commit that referenced this pull request Mar 23, 2022
@deepak1556
fix: iocp integration when process is reused (#33207) (#33363)
45e14a5
bavulapati pushed a commit to bavulapati/electron that referenced this pull request Apr 29, 2022
@deepak1556 @bavulapati
fix: iocp integration when process is reused (electron#33207)
94ce269
@commit-lint commit-lint bot mentioned this pull request May 6, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@deepak1556 @khalwa
fix: iocp integration when process is reused (electron#33207)
5c675a6
@dtychshenko dtychshenko mentioned this pull request May 19, 2023
Closed
3 tasks
@codebytere codebytere mentioned this pull request Jul 12, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: callback didn't executed with process.nextTick and setImmediate Windows socket and named pipe servers don't work in main process
2 participants
@deepak1556 @zcbenz
0