8000 fix: don't unmaximize on macOS if user set max bounds by trop[bot] · Pull Request #33552 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: don't unmaximize on macOS if user set max bounds #33552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

fix: don't unmaximize on macOS if user set max bounds #33552

merged 1 commit into from
Mar 31, 2022

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Mar 31, 2022

Backport of #33480

See that PR for details.

Notes: Fixed an issue where the the window bounds would incorrectly change if BrowserWindow.unmaximize was called on a window whose user bounds were maximized.

@trop trop bot requested a review from codebytere March 31, 2022 08:34
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 31, 2022
@trop trop bot mentioned this pull request Mar 31, 2022
Merged
4 tasks
@trop trop bot added 16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 31, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 31, 2022
@jkleinsc jkleinsc merged commit ba8a158 into 16-x-y Mar 31, 2022
@jkleinsc jkleinsc deleted the trop/16-x-y-bp-fix-don-t-unmaximize-on-macos-if-user-set-max-bounds-1648715667537 branch March 31, 2022 14:22
@release-clerk
Copy link
release-clerk bot commented Mar 31, 2022

Release Notes Persisted

Fixed an issue where the the window bounds would incorrectly change if BrowserWindow.unmaximize was called on a window whose user bounds were maximized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
16-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @codebytere
0