8000 chore: cherry-pick 891020ed64d4 from angle by ppontes · Pull Request #32224 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: cherry-pick 891020ed64d4 from angle #32224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2022
Merged

chore: cherry-pick 891020ed64d4 from angle #32224

merged 3 commits into from
Jan 10, 2022

Conversation

ppontes
Copy link
Member
@ppontes ppontes commented Dec 16, 2021 •
edited
Loading

[M96] Ignore the pixel unpack state for compressed textures.

From OpenGL ES 3 spec: All pixel storage modes are ignored when decoding
a compressed texture image
This was causing a bad access when calling compressedTexImage3D
with GL_UNPACK_IMAGE_HEIGHT greater than the image height.

Bug: chromium:1267496
Change-Id: I9b1f4c645548af64f2695fd23262225a1ad07cd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296622
Commit-Queue: Jonah Ryan-Davis jonahr@google.com
Reviewed-by: Geoff Lang geofflang@chromium.org
Reviewed-by: Shahbaz Youssefi syoussefi@chromium.org
(cherry picked from commit 870f458f507ff7ba0f67b28a30a27955ce79dd3e)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3309097
Reviewed-by: Jonah Ryan-Davis jonahr@google.com
Reviewed-by: Jamie Madill jmadill@chromium.org

Notes: Backported fix for CVE-2021-4058.

@ppontes ppontes requested a review from a team as a code owner December 16, 2021 21:39
@ppontes ppontes added 14-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Dec 16, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Dec 16, 2021
@codebytere
Copy link
Member

Failure unrelated.

@codebytere codebytere merged commit 0e0bf54 into 14-x-y Jan 10, 2022
@codebytere codebytere deleted the cherry-pick/14-x-y/angle/891020ed64d4 branch January 10, 2022 11:49
@release-clerk
Copy link
release-clerk bot commented Jan 10, 2022

Release Notes Persisted

Backported fix for CVE-2021-4058.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
14-x-y backport-check-skip Skip trop's backport validity checking security 🔒 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppontes @codebytere @zcbenz @electron-bot
0